)]}'
{"id":"CalyxOS%2Fplatform_external_webp~20327","triplet_id":"CalyxOS%2Fplatform_external_webp~android13~I31c36dbf3aa78d35ecf38706b50464fd3d375741","project":"CalyxOS/platform_external_webp","branch":"android13","topic":"sep23","hashtags":[],"change_id":"I31c36dbf3aa78d35ecf38706b50464fd3d375741","subject":"Fix OOB write in BuildHuffmanTable.","status":"MERGED","created":"2023-09-19 08:51:02.000000000","updated":"2023-09-19 11:46:25.000000000","submitted":"2023-09-19 11:46:25.000000000","submitter":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"20327-sep23","meta_rev_id":"340c45f75d2c14388b981345f7ecbaded7dc8144","_number":20327,"virtual_id_number":20327,"owner":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2023-09-19 11:35:53.000000000","_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Builds":{"all":[{"value":0,"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Builds"},"description":"","default_value":0,"optional":true},"Works":{"approved":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2023-09-19 11:46:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Works"},"description":"","default_value":0,"optional":true},"Bypass-Verification":{"all":[{"value":0,"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{" 0":"No score","+1":"YOLO"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"35ee5396579e0ff799976cac387a984c415d6581","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 08:51:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0cc7a115553b68d4f1e5fe005ad0957991136eb0","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 08:51:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1f6233a377c389d4b26429de16aab347f8962501","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 08:51:37.000000000","message":"Topic set to sep23","accounts_in_message":[],"_revision_number":1},{"id":"788eacbd4fb42c628d36926ff640ed7ed6b1ee7e","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 11:35:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"90fd1ccd315397efb8b070858ad906882ccf10d9","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 11:46:23.000000000","message":"Patch Set 1: Works+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"340c45f75d2c14388b981345f7ecbaded7dc8144","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2023-09-19 11:46:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0c955b633f1231835101fef537d315a3fb13686c","revisions":{"0c955b633f1231835101fef537d315a3fb13686c":{"kind":"REWORK","_number":1,"created":"2023-09-19 08:51:02.000000000","uploader":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/27/20327/1","fetch":{"anonymous http":{"url":"https://review.calyxos.org/CalyxOS/platform_external_webp","ref":"refs/changes/27/20327/1","commands":{"Branch":"git fetch https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1 \u0026\u0026 git checkout -b change-20327 FETCH_HEAD","Checkout":"git fetch https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1","Reset To":"git fetch https://review.calyxos.org/CalyxOS/platform_external_webp refs/changes/27/20327/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3dbefd1d0407298eb9c2692c959bd77a300ba46","subject":"Add git-review configuration","web_links":[{"name":"GitLab","tooltip":"Open in GitWeb","url":"https://gitlab.com/CalyxOS/platform_external_webp/-/commit/a3dbefd1d0407298eb9c2692c959bd77a300ba46"}]}],"author":{"name":"Vincent Rabaud","email":"vrabaud@google.com","date":"2023-09-07 19:16:03.000000000","tz":120},"committer":{"name":"Chirayu Desai","email":"chirayudesai1@gmail.com","date":"2023-09-19 08:50:54.000000000","tz":330},"subject":"Fix OOB write in BuildHuffmanTable.","message":"Fix OOB write in BuildHuffmanTable.\n\nFirst, BuildHuffmanTable is called to check if the data is valid.\nIf it is and the table is not big enough, more memory is allocated.\n\nThis will make sure that valid (but unoptimized because of unbalanced\ncodes) streams are still decodable.\n\nBug: chromium:1479274\nChange-Id: I31c36dbf3aa78d35ecf38706b50464fd3d375741\n(cherry picked from commit 902bc9190331343b2017211debcec8d2ab87e17a)\n(cherry picked from commit 2af26267cdfcb63a88e5c74a85927a12d6ca1d76)\n","web_links":[{"name":"GitLab","tooltip":"Open in GitWeb","url":"https://gitlab.com/CalyxOS/platform_external_webp/-/commit/0c955b633f1231835101fef537d315a3fb13686c"}],"resolve_conflicts_web_links":[{"name":"GitLab","tooltip":"Open in GitWeb","url":"https://gitlab.com/CalyxOS/platform_external_webp/-/commit/0c955b633f1231835101fef537d315a3fb13686c"}]},"branch":"refs/heads/android13"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Builds","status":"MAY"},{"label":"Works","status":"MAY","applied_by":{"_account_id":1000000,"name":"Chirayu Desai","display_name":"Chirayu Desai","username":"chirayudesai","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Bypass-Verification","status":"MAY"}]}],"submit_requirements":[{"name":"Code-Review","description":"A maximum vote is required for the \u0027Code-Review\u0027 label. A minimum vote is blocking.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Builds","description":"Make sure it builds. A minimum vote is blocking.","status":"OVERRIDDEN","is_legacy":false,"submittability_expression_result":{"expression":"label:Builds\u003dMAX AND -label:Builds\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Builds\u003dMAX","label:Builds\u003dMIN"],"atom_explanations":{}},"override_expression_result":{"expression":"label:Builds\u003d0 AND (label:Works\u003dMAX OR label:Bypass-Verification\u003dMAX)","fulfilled":true,"status":"PASS","passing_atoms":["label:Works\u003dMAX","label:Builds\u003d0"],"failing_atoms":["label:Bypass-Verification\u003dMAX"],"atom_explanations":{}}},{"name":"Works","description":"Make sure it works. A minimum vote is blocking.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Works\u003dMAX AND -label:Works\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Works\u003dMAX"],"failing_atoms":["label:Works\u003dMIN"],"atom_explanations":{}},"override_expression_result":{"expression":"label:Works\u003d0 AND label:Bypass-Verification\u003dMAX","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Bypass-Verification\u003dMAX","label:Works\u003d0"],"atom_explanations":{}}}]}